Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix the DLL import issue on python 3.8 or higher on windows #387

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

pjueon
Copy link
Contributor

@pjueon pjueon commented Jul 21, 2022

Related to #247 #349
Tested on python 3.9.2 & windows 10 / windows 11

on python 3.8 or higher on windows
@AnderBiguri
Copy link
Member

Oh, fantastic!
Super important update, I really appreciate it.

Let me test on my side, but I see no problem to merge.

@pjueon
Copy link
Contributor Author

pjueon commented Jul 21, 2022

Wow, thanks for the incredibly fast response.
Please note that I only tested on windows. It should work on linux too but I haven't tested yet.

@AnderBiguri
Copy link
Member

Should not be a problem in Linux, as Linux doesn't use dlls. I will test nevertheless.

@tsadakane
Copy link
Contributor

Great!
Your PR fixes a problem on Python 3.10 that I reported in #375 (comment) (I am sorry. Building TIGRE was OK and the error was at runtime.)
Thank you very much.

@AnderBiguri AnderBiguri merged commit 029c789 into CERN:master Jul 22, 2022
@pjueon pjueon deleted the fix-dll-import-python3.8-windows branch July 22, 2022 10:44
@pjueon pjueon mentioned this pull request Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants